Shirly Radco has posted comments on this change.

Change subject: history: update user and system cpu usage percent
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.ovirt.org/#/c/27556/5/packaging/dbscripts/upgrade/03_05_0020_update_cpu_usage_percent.sql
File packaging/dbscripts/upgrade/03_05_0020_update_cpu_usage_percent.sql:

Line 1: -- add new columns for hourly sys and user cpu usage percent
> change to add temp columns. Please add a explanation of the problem and bug
Done
Line 2: SELECT fn_db_add_column('statistics_vms_users_usage_hourly', 
'user_cpu_usage_percent_temp', 'smallint');
Line 3: SELECT fn_db_add_column('statistics_vms_users_usage_hourly', 
'max_user_cpu_usage_percent_temp', 'smallint');
Line 4: SELECT fn_db_add_column('statistics_vms_users_usage_hourly', 
'system_cpu_usage_percent_temp', 'smallint');
Line 5: SELECT fn_db_add_column('statistics_vms_users_usage_hourly', 
'max_system_cpu_usage_percent_temp', 'smallint');


Line 63: SELECT __temp_hourly_cpu_usage_percent();
Line 64: 
Line 65: DROP function __temp_hourly_cpu_usage_percent();
Line 66: 
Line 67: --delete user and sys cpu_usage_percentcolumns from 
statistics_vms_users_usage_hourly table
> missing space
Done
Line 68: SELECT fn_db_drop_column('statistics_vms_users_usage_hourly', 
'user_cpu_usage_percent');
Line 69: SELECT fn_db_drop_column('statistics_vms_users_usage_hourly', 
'max_user_cpu_usage_percent');
Line 70: SELECT fn_db_drop_column('statistics_vms_users_usage_hourly', 
'system_cpu_usage_percent');
Line 71: SELECT fn_db_drop_column('statistics_vms_users_usage_hourly', 
'max_system_cpu_usage_percent');


-- 
To view, visit http://gerrit.ovirt.org/27556
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia47326f94b0b1b696d0bcaf13b5f6df0093b9196
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <[email protected]>
Gerrit-Reviewer: Shirly Radco <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to