Omer Frenkel has posted comments on this change. Change subject: core: copy disks from template instead of instance type ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/27630/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java: Line 807: * If both the instance type and the template is set, than all the devices has to be copied from instance type except the Line 808: * disk devices which has to be copied from the template (since the instance type has no disks but the template does have). Line 809: */ Line 810: private void copyDiskDevicesFromTemplate() { Line 811: List<VmDevice> disks = DbFacade.getInstance().getVmDeviceDao().getVmDeviceByVmIdAndType(getVmTemplateId(), VmDeviceGeneralType.DISK); i am sorry my comment in the previous patch was wrong, i meant: please use vmDisksSource instead of templateId Line 812: VmDeviceUtils.copyVmDevices( Line 813: getVmTemplateId(), Line 814: getVmId(), Line 815: getVm(), Line 809: */ Line 810: private void copyDiskDevicesFromTemplate() { Line 811: List<VmDevice> disks = DbFacade.getInstance().getVmDeviceDao().getVmDeviceByVmIdAndType(getVmTemplateId(), VmDeviceGeneralType.DISK); Line 812: VmDeviceUtils.copyVmDevices( Line 813: getVmTemplateId(), also here Line 814: getVmId(), Line 815: getVm(), Line 816: getVm().getStaticData(), Line 817: true, -- To view, visit http://gerrit.ovirt.org/27630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaddc4d3da99c0a459c7339639cca15cbb597df18 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
