Omer Frenkel has posted comments on this change. Change subject: core: VdsManager - pulling more methods up to the facade ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27376/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 275: _vds.getStatus() != VDSStatus.PendingApproval && _vds.getStatus() != VDSStatus.Down); Line 276: } Line 277: Line 278: @Override Line 279: public void handleVdsRecoveringException(VDSRecoveringException ex) { why public? Line 280: if (_vds.getStatus() != VDSStatus.Initializing && _vds.getStatus() != VDSStatus.NonOperational) { Line 281: setStatus(VDSStatus.Initializing, _vds); Line 282: DbFacade.getInstance().getVdsDynamicDao().updateStatus(_vds.getId(), VDSStatus.Initializing); Line 283: AuditLogableBase logable = new AuditLogableBase(_vds.getId()); -- To view, visit http://gerrit.ovirt.org/27376 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a3d406c4f65ba7f437c699c97908f531e89d4d7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
