Moti Asayag has uploaded a new change for review. Change subject: engine: Maintain lowercase mac addresses ......................................................................
engine: Maintain lowercase mac addresses The mac addresses used to be stored in lowercase. This patch preserves that old behaviour. Change-Id: Ia2fb0ce1baed6882381065a2cd3eec58ce60302a Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MacAddressRangeUtilsTest.java 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/07/27707/1 diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java index b3dd7f1..3ecfded 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java @@ -50,7 +50,7 @@ } public static String macToString(long macAddress) { - String value = String.format("%012x", macAddress).toUpperCase(); + String value = String.format("%012x", macAddress); char[] chars = value.toCharArray(); final StringBuilder stringBuilder = new StringBuilder(); diff --git a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MacAddressRangeUtilsTest.java b/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MacAddressRangeUtilsTest.java index 9131237..fe183c1 100644 --- a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MacAddressRangeUtilsTest.java +++ b/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MacAddressRangeUtilsTest.java @@ -8,7 +8,7 @@ @Test public void testMacToString() throws Exception { - final String macString = "00:1A:4A:01:00:00"; + final String macString = "00:1a:4a:01:00:00"; final long macLong = 112910729216L; Assert.assertThat(MacAddressRangeUtils.macToString(macLong), CoreMatchers.is(macString)); -- To view, visit http://gerrit.ovirt.org/27707 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia2fb0ce1baed6882381065a2cd3eec58ce60302a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
