Martin Peřina has posted comments on this change. Change subject: core: Provide informations about fencing in RHEV-M ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27706/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 673: long timeoutToFence = calcTimeoutToFence(vds.getVmCount(), vds.getSpmStatus()); Line 674: log.warnFormat("Host {0} is not responding, Host will be in Connecting state for a grace period of {1} Sec and after that an attempt to fence the Host will be issued.", vds.getName(), TimeUnit.MILLISECONDS.toSeconds(timeoutToFence)); Line 675: AuditLogableBase logable = new AuditLogableBase(); Line 676: logable.setVdsId(vds.getId()); Line 677: logable.addCustomValue("Seconds", new Long(TimeUnit.MILLISECONDS.toSeconds(timeoutToFence)).toString()); Also no need of new Long(...).toString(), there's a static method Long.toString(...) Line 678: AuditLogDirector.log(logable, AuditLogType.VDS_HOST_IN_CONNECTING_STATE); Line 679: if (mUnrespondedAttempts.get() < Config.<Integer> getValue(ConfigValues.VDSAttemptsToResetCount) Line 680: || (lastUpdate + timeoutToFence) > System.currentTimeMillis()) { Line 681: boolean result = false; -- To view, visit http://gerrit.ovirt.org/27706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f9aa1711f9b47b7a5a3b805da4002e3fbbe24be Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
