Frank Kobzik has uploaded a new change for review. Change subject: frontend: minor instance type correction ......................................................................
frontend: minor instance type correction This patch removes deactivating and activating instance type manager when display type of entity changes. Change-Id: I85f2301e12b194c8373d7f531e077e52d49b9d02 Signed-off-by: Frantisek Kobzik <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java 2 files changed, 2 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/17/27717/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java index 77773f9..2c46906 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java @@ -1615,12 +1615,8 @@ } else if (sender == getDisplayProtocol()) { - deactivateInstanceTypeManagerAndUpdateFields(); - displayProtocol_SelectedItemChanged(sender, args); initUsbPolicy(); - - getBehavior().activateInstanceTypeManager(); } else if (sender == getNumOfSockets()) { diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java index 3bf3dd7..04c2d6f 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java @@ -32,7 +32,7 @@ /** * Base class which takes care about copying the proper fields from instance type/template/vm static to the VM. * - * Please not that this class manages only the fields which are defined on the instance type, so the + * Please note that this class manages only the fields which are defined on the instance type, so the * fields which are taken from the template and are not from instance type have to be handled on some * different place (most often in the behavior classes). * @@ -72,7 +72,7 @@ } /** - * First updates the list of instance types and selects the one which is supposed to be selected and than + * First updates the list of instance types and selects the one which is supposed to be selected and then * updates all the fields which are taken from the instance type (by calling the updateFields()). */ public void updateAll() { -- To view, visit http://gerrit.ovirt.org/27717 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I85f2301e12b194c8373d7f531e077e52d49b9d02 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
