Maor Lipchuk has posted comments on this change.

Change subject: core: Add vdc query to check if an entity if unregistered.
......................................................................


Patch Set 14:

(2 comments)

http://gerrit.ovirt.org/#/c/26484/14/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredVmTemplatesQuery.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredVmTemplatesQuery.java:

Line 7: import org.ovirt.engine.core.common.businessentities.VmTemplate;
Line 8: import org.ovirt.engine.core.common.queries.IdAndNameQueryParameters;
Line 9: 
Line 10: public class GetUnregisteredVmTemplatesQuery<P extends 
IdAndNameQueryParameters> extends QueriesCommandBase<P> {
Line 11:     public GetUnregisteredVmTemplatesQuery(P parameters) {
> please add a flag for adding full content of the vm (i.e. vm from configura
done
Line 12:         super(parameters);
Line 13:     }
Line 14: 
Line 15:     @Override


http://gerrit.ovirt.org/#/c/26484/14/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResource.java
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResource.java:

Line 1: package org.ovirt.engine.api.restapi.resource;
Line 2: 
Line 3: import java.util.ArrayList;
> not related to the patch - please extract
done
Line 4: import java.util.Collection;
Line 5: import java.util.List;
Line 6: 
Line 7: import javax.ws.rs.core.Response;


-- 
To view, visit http://gerrit.ovirt.org/26484
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83a937dcc8cd86d7f88f643bb7ba0f03d27a8ee6
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to