Sandro Bonazzola has posted comments on this change.

Change subject: packaging: allow to override sos version
......................................................................


Patch Set 6: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/27691/6/configure.ac
File configure.ac:

Line 71:     [AS_HELP_STRING([--with-sos-version], [sos version to use])],
Line 72:     [SOS_VERSION="${withval}"],
Line 73:     [
Line 74:         AX_PYTHON_MODULE([sos], [fatal])
Line 75:         SOS_VERSION="$(${PYTHON} -c "import sos; 
print(sos.__version__.split('.', 2)[[0]])"  2>/dev/null)"
> nice! the [ ] caused the issue :)
Ok, merging this. Let me know if you need anything else on gentoo.
Line 76:     ]
Line 77: )
Line 78: 
Line 79: AC_MSG_CHECKING([sos version])


-- 
To view, visit http://gerrit.ovirt.org/27691
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5c6cd685f5bf7f7c1b49dc769e46bb6aa3adfff
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to