Alon Bar-Lev has posted comments on this change.

Change subject: core : Allow redirection of all logs using extension
......................................................................


Patch Set 17:

ravi, please add ignore to the findbug issues, something like:

  <Match>
    <Class name="org.ovirt.engine.core.logger.LoggerHandler" />
    <Method name="publish"/>
    <Bug pattern="DE_MIGHT_IGNORE"/>
  </Match>
  <Match>
    <Class name="org.ovirt.engine.core.logger.LoggerHandler" />
    <Method name="flush"/>
    <Bug pattern="DE_MIGHT_IGNORE"/>
  </Match>
  <Match>
    <Class name="org.ovirt.engine.core.logger.LoggerHandler" />
    <Method name="close"/>
    <Bug pattern="DE_MIGHT_IGNORE"/>
  </Match>

-- 
To view, visit http://gerrit.ovirt.org/27431
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0dae8ffe53c3489af06d6684c72e6b431002404
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to