Sandro Bonazzola has posted comments on this change. Change subject: build: ovirt-release35-1.0.0_alpha1 ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/27755/2/ovirt-release-3.5/configure.ac File ovirt-release-3.5/configure.ac: Line 19: Line 20: define([VERSION_MAJOR], [1]) Line 21: define([VERSION_MINOR], [0]) Line 22: define([VERSION_FIX], [0]) Line 23: define([VERSION_NUMBER], VERSION_MAJOR[.]VERSION_MINOR[.]VERSION_FIX) > can we just have version 001 or something? this is downstream only package, ok on my side. we'll need to use epoch=1 for changing versioning schema on 3.4. Kiril? Line 24: define([VERSION_SUFFIX], [_alpha1]) Line 25: define([OVIRT_VERSION_MAJOR], [3]) Line 26: define([OVIRT_VERSION_MINOR], [5]) Line 27: http://gerrit.ovirt.org/#/c/27755/2/ovirt-release-3.5/ovirt.repo.in File ovirt-release-3.5/ovirt.repo.in: Line 1: [ovirt-@OVIRT_SLOT@-pre] Line 2: name=Latest oVirt @OVIRT_SLOT@ Pre Release Line 3: #baseurl=http://resources.ovirt.org/pub/ovirt-@OVIRT_SLOT@_pre/rpm/@DIST@$releasever/ Line 4: mirrorlist=http://resources.ovirt.org/pub/yum-repo/mirrorlist-ovirt-@OVIRT_SLOT@_pre-@DIST@$releasever > I think it can be at the -rc and have it rolling. I'm not sure to have understood. Is _pre suffix ok or do you think something else should be used? Line 5: enabled=1 Line 6: skip_if_unavailable=1 Line 7: gpgcheck=1 -- To view, visit http://gerrit.ovirt.org/27755 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If75f973c737818a113a6e79a641c12773419af45 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
