Michael Pasternak has posted comments on this change. Change subject: core: Do not fail on internal disconnect-at-constructor ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27753/1/src/ovirtsdk/api.py File src/ovirtsdk/api.py: Line 92: Line 93: # Implicitly disconnect and perform cleanup Line 94: # when detected instance of the SDK proxy with Line 95: # ref-count == 0 Line 96: if context.manager.has_key(self.__id): actually the right solution is this: 1. if context.manager.has_key(self.__id) and context.manager[self.__id].get('proxy') is not None: 2. no change is required in disconnect() Line 97: try: Line 98: self.disconnect() Line 99: except DisconnectedError: Line 100: pass # Or do something else? What? -- To view, visit http://gerrit.ovirt.org/27753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14e8e8ca00a99263227053a47129b93bcb27b7d1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
