Martin Peřina has posted comments on this change. Change subject: tools: Fixing RootDSEData bind ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27756/1/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/RootDSEData.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/RootDSEData.java: Line 59: env.put(Context.SECURITY_CREDENTIALS, ""); Line 60: env.put(Context.REFERRAL, "follow"); Line 61: env.put(Context.PROVIDER_URL, url); Line 62: env.put(Context.INITIAL_CONTEXT_FACTORY, Line 63: "com.sun.jndi.ldap.LdapCtxFactory"); Why to put value on new line? It will fit into 120 characters limit without problem ... Line 64: try { Line 65: dirContext = new InitialDirContext(env); Line 66: SearchControls controls = RootDSEQueryInfo.createSearchControls(); Line 67: String query = RootDSEQueryInfo.ROOT_DSE_LDAP_QUERY; -- To view, visit http://gerrit.ovirt.org/27756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b5709ba7f01eb34cfb72f271f3963e0e635f2a5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
