Michael Kublin has posted comments on this change. Change subject: core: replace vm id with number of vms in views. ......................................................................
Patch Set 1: Do not submit (1 inline comment) Let me understand correct, you removed a field from view and its mapping, but field is still left at java object Disk.getvm_guid() so it is a partial patch or what, I hope you understand that these patch will brake almost every scenario.... Also we already talked about that a dynamic calculation at views it is a bad performance -2 - will brake everything, that patch is not full with out changes at BLL logic .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java Line 21: private VmEntityType vmEntityType; Agree with Allon, should be int. Integer if a value can be null, int if not. For that case the field is not null, so use int. All other reasons are not related -- To view, visit http://gerrit.ovirt.org/5216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id306d8322245780ea200c10f9e96254cddf3bc76 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
