Alexander Wels has posted comments on this change. Change subject: webadmin: auto select dialog tab ......................................................................
Patch Set 2: Verified+1 I centralized the logic to select the proper tab in a dialog if the tab is invalid. All the popups with tabs that I could find now properly select invalid tabs. However, the pool and VMs seem to not be properly validated (for instance I can set the minimum memory to 0 on the pool) and it will validate fine. I will double check if this is broken in master, but I didn't change the logic. -- To view, visit http://gerrit.ovirt.org/27781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e9c5ad0cd3ee7f54606958b1fc8abd2bbd972ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
