Alon Bar-Lev has posted comments on this change. Change subject: aaa: Chages to ExtensionsManager ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/27785/3/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 120: private Map<String, BindingsLoader> bindingsLoaders = new HashMap<>(); Line 121: private Map<String, ExtensionEntry> loadedEntries = new HashMap<>(); Line 122: private ExtMap globalContext = new ExtMap().mput(Base.GlobalContextKeys.EXTENSIONS, new ArrayList<ExtMap>()); Line 123: Line 124: private Properties configProperties = new Properties(); > We would like utils to depend on extension-manager. oh... the enable/disable? now I get it! I think that you should feed it via setExtensionState(name, status) method. this way you can call these before loading anything, without depend on the specific format of engine. Line 125: Line 126: public ExtMap getGlobalContext() { Line 127: return globalContext; Line 128: } -- To view, visit http://gerrit.ovirt.org/27785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
