Moti Asayag has posted comments on this change. Change subject: engine: Upgrade to JUnit 4.11 ......................................................................
Patch Set 3: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/27773/3//COMMIT_MSG Commit Message: Line 14: Line 15: 1. Removed static modifier from members annotated with the @Rule Line 16: annotation, as this is no longer allowed, or replaced it with Line 17: @ClassRule wherever possible. Line 18: Note that having a static @Rule, if if allowed in earlier versions of please delete the extra 'if' Line 19: JUnit is probably a hidden bug just waiting to happen. Line 20: Line 21: 2. Replaced usages of JUnitMatchers, which is now deprecated, with the Line 22: standard CoreMatchers. -- To view, visit http://gerrit.ovirt.org/27773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ab9c817ac6390bd12c725b5655dbd3fdf6d0c61 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
