Moti Asayag has posted comments on this change. Change subject: engine: Add network name to "network used" error message ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/25839/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java: Line 133: for (Network otherNetwork : getNetworks()) { Line 134: if (otherNetwork.getName().equals(network.getName()) && Line 135: !otherNetwork.getId().equals(network.getId())) { Line 136: return new ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_NETWORK_NAME_IN_USE, Line 137: String.format("$NetworkName %s", network.getName())); this can be extracted into a method since appears exactly in the next method, i.e. getNetworkNameReplacement() Line 138: } Line 139: } Line 140: return ValidationResult.VALID; Line 141: } http://gerrit.ovirt.org/#/c/25839/4/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 501: -Please attach Data Domain to the Data Center first. Line 502: ERROR_CANNOT_REMOVE_POOL_WITH_ACTIVE_DOMAINS=Cannot remove Data Center which contains active/locked Storage Domains.\n\ Line 503: -Please deactivate all domains and wait for tasks to finish before removing the Data Center. Line 504: VDS_GROUP_CANNOT_CHANGE_STORAGE_POOL=Cannot change Data Center association when editing a Cluster. Line 505: ACTION_TYPE_FAILED_NETWORK_NAME_IN_USE=Cannot ${action} ${type}. The name of the logical network '${NetworkName}' is already used by an existing logical network in the same data-center.\n\ it doesn't part of this patch, but this message shouldn't be included here, as no representation for networks on user portal. Line 506: -Please choose a different name. Line 507: ACTION_TYPE_FAILED_NETWORK_IN_USE=Cannot ${action} ${type}. Several ${entities} (${ENTITIES_USING_NETWORK_COUNTER}) are using this logical network:\n${ENTITIES_USING_NETWORK}\n - Please remove it from all ${entities} that are using it and try again. Line 508: ERROR_CANNOT_CREATE_STORAGE_DOMAIN_WITHOUT_VG_LV=Volume Group (VGs) and Logical Volumes (LVs) are not specified. Line 509: NETWORK_INTERFACE_TEMPLATE_CANNOT_BE_SET=Cannot ${action} ${type}. VM Template ID must be empty. -- To view, visit http://gerrit.ovirt.org/25839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I238d57ac3ae943aed312f45a2e6b7b4978b8f95b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
