Yair Zaslavsky has posted comments on this change. Change subject: aaa: Remove dependency at builtin on Common config ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/27607/8/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/Utils.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/Utils.java: Line 21: public static void putDefaultsIfAbsent(Properties conf) { Line 22: { Line 23: Properties defaults = new Properties(); Line 24: try { Line 25: defaults.load(Utils.class.getResourceAsStream("/builtin/defaults.properties")); > 1. class loader loads 10 classes I assume the classes do not reside in the same jar. If reside in the same jar - no problem. In case of different jars - it will the resource that is attached to the jar that contains the class for which we obtained the class loader. Using an fqdn will not give you 100% protection either. I can create in both projects a sub directory under resources that translates the same FQDN. Line 26: for (Map.Entry<Object, Object> entry : defaults.entrySet()) { Line 27: putIfAbsent(conf, (String) entry.getKey(), (String) entry.getValue()); Line 28: } Line 29: -- To view, visit http://gerrit.ovirt.org/27607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1384a99f73ab605b61bce8dcdfd63e222b0001fa Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
