Yair Zaslavsky has posted comments on this change. Change subject: aaa: Changes to ExtensionsManager ......................................................................
Patch Set 17: (3 comments) http://gerrit.ovirt.org/#/c/27785/17/backend/manager/modules/extensions-manager/src/main/modules/org/ovirt/engine/core/extensions-manager/main/module.xml File backend/manager/modules/extensions-manager/src/main/modules/org/ovirt/engine/core/extensions-manager/main/module.xml: Line 6 Line 7 Line 8 Line 9 Line 10 > I do not think we need javax Done Line 8 Line 9 Line 10 Line 11 Line 12 > why do we need commons lang? Done Line 11: <module name="javax.servlet.api"/> Line 12: <module name="org.apache.commons.lang"/> Line 13: <module name="org.jboss.modules"/> Line 14: <module name="org.ovirt.engine.api.ovirt-engine-extensions-api"/> Line 15: <module name="org.ovirt.engine.core.utils"/> > why do you need utils? no need. i'll fix. Line 16: <module name="org.slf4j"/> Line 17: </dependencies> Line 18: -- To view, visit http://gerrit.ovirt.org/27785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
