Alon Bar-Lev has posted comments on this change. Change subject: aaa: Extensions tester tool ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/27814/6/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/ExtensionsTool.java File backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/ExtensionsTool.java: Line 13: import org.ovirt.engine.api.extensions.ExtMap; Line 14: import org.ovirt.engine.api.extensions.ExtUUID; Line 15: import org.ovirt.engine.api.extensions.aaa.Authn; Line 16: import org.ovirt.engine.api.extensions.aaa.Authz; Line 17: import org.ovirt.engine.core.aaa.SearchQueryParsingUtils; > Well, I understand your claim, but if I copy this function to two places, a now think that this component is a different project written by different person... also... please notice that the search here can be done on single namespace while the engine has no such ability. and engine module will probably pull more dependencies, so we cannot split this extension-manager, extension-tool, extension-api into own repo. Line 18: import org.ovirt.engine.core.extensions.mgr.ExtensionProxy; Line 19: import org.ovirt.engine.core.extensions.mgr.ExtensionsManager; Line 20: Line 21: public class ExtensionsTool { -- To view, visit http://gerrit.ovirt.org/27814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
