Lior Vernia has posted comments on this change. Change subject: engine: Simplify code in UpdateVdsGroupCommand ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/27831/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java: Line 84 Line 85 Line 86 Line 87 Line 88 > the second part of this condition is for assigning a new data-center to the You're correct. Since the first part is blocked however, the last block of code can be removed, can't it? Line 106 Line 107 Line 108 Line 109 Line 110 > when data-center is being removed, its networks are being deleted as well. Indeed. Simplified the code however, by using the fact that the management network doesn't exist only when oldVdsGroup is null, and thus no network is assigned to the cluster (otherwise the current code wouldn't be valid either, since other networks could occupy roles). -- To view, visit http://gerrit.ovirt.org/27831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0091d9afb6d4b26c4ba9fb434192a56eda9397e4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
