Shirly Radco has uploaded a new change for review.

Change subject: reports: dr18 report - added comments to queries
......................................................................

reports: dr18 report - added comments to queries

Changed the code structure so it will be more readable
and added commets.

Change-Id: I3193e16cd226a91e4f44084555763c48b3360100
Signed-off-by: Shirly Radco <[email protected]>
---
M 
packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/jrxmls/top_five_hosts_downtime_dr18_jrxml.data
1 file changed, 82 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-reports refs/changes/84/27884/1

diff --git 
a/packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/jrxmls/top_five_hosts_downtime_dr18_jrxml.data
 
b/packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/jrxmls/top_five_hosts_downtime_dr18_jrxml.data
index ba1798e..8d854c6 100644
--- 
a/packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/jrxmls/top_five_hosts_downtime_dr18_jrxml.data
+++ 
b/packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/jrxmls/top_five_hosts_downtime_dr18_jrxml.data
@@ -1,23 +1,90 @@
 <?xml version="1.0" encoding="UTF-8"?>
+<!-- Created with Jaspersoft Studio version 5.5.0-->
 <jasperReport xmlns="http://jasperreports.sourceforge.net/jasperreports"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://jasperreports.sourceforge.net/jasperreports 
http://jasperreports.sourceforge.net/xsd/jasperreport.xsd"; 
name="top_five_hosts_downtime_dr18" language="groovy" pageWidth="445" 
pageHeight="260" whenNoDataType="AllSectionsNoDetail" columnWidth="445" 
leftMargin="0" rightMargin="0" topMargin="0" bottomMargin="0" 
resourceBundle="ovirt_reports_bundle" whenResourceMissingType="Error" 
uuid="79132293-de9a-497e-86cb-16aa02a41a0b">
        <property name="ireport.zoom" value="1.0"/>
        <property name="ireport.x" value="0"/>
        <property name="ireport.y" value="0"/>
-       <property name="ireport.jasperserver.reportUnit" 
value="/reports_resources/webadmin_dashboards/ce/cluster_dashboard"/>
-       <property name="ireport.jasperserver.url" 
value="http://localhost:8080/jasperserver-pro/services/repository"/>
-       <parameter name="P_Cluster_ID" class="java.lang.String">
-               <defaultValueExpression><![CDATA[]]></defaultValueExpression>
-       </parameter>
-       <queryString>
-               <![CDATA[SELECT v3_5_latest_configuration_hosts.host_id, 
v3_5_latest_configuration_hosts.host_name,
-       (SUM(CASE WHEN 
v3_5_statistics_hosts_resources_usage_samples.host_status = 1 THEN 
coalesce(v3_5_statistics_hosts_resources_usage_samples.minutes_in_status,0) 
ELSE 0 END) / 
SUM(v3_5_statistics_hosts_resources_usage_samples.minutes_in_status)) * 100 as 
uptime_percent,
-       (SUM(CASE WHEN 
v3_5_statistics_hosts_resources_usage_samples.host_status = 2 THEN 
coalesce(v3_5_statistics_hosts_resources_usage_samples.minutes_in_status,0) 
ELSE 0 END) / 
SUM(v3_5_statistics_hosts_resources_usage_samples.minutes_in_status)) * 100 AS 
planned_downtime_percent,
-       (SUM(CASE WHEN 
v3_5_statistics_hosts_resources_usage_samples.host_status = 3 THEN 
coalesce(v3_5_statistics_hosts_resources_usage_samples.minutes_in_status,0) 
ELSE 0 END) / 
SUM(v3_5_statistics_hosts_resources_usage_samples.minutes_in_status)) * 100 AS 
unplanned_downtime_percent
+       <property name="ireport.jasperserver.url" 
value="http://localhost:8080/jasperserver-pro/"/>
+       <property name="ireport.jasperserver.report.resource" 
value="/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/jrxmls/top_five_hosts_downtime_dr18_jrxml"/>
+       <parameter name="P_Cluster_ID" class="java.lang.String"/>
+       <queryString language="SQL">
+               <![CDATA[-- DR18 - This query returns for 5 hosts,
+-- that have downtime percent, the total uptime,
+-- planned and unplanned downtime percent.
+
+SELECT
+    v3_5_latest_configuration_hosts.host_id, 
v3_5_latest_configuration_hosts.host_name,
+    (
+        SUM (
+            CASE
+                WHEN
+                    v3_5_statistics_hosts_resources_usage_samples.host_status 
= 1
+                    THEN
+                        COALESCE (
+                            
v3_5_statistics_hosts_resources_usage_samples.minutes_in_status,
+                            0
+                        )
+                ELSE 0
+            END
+        ) /
+        SUM (
+            v3_5_statistics_hosts_resources_usage_samples.minutes_in_status
+        )
+    ) * 100
+    AS uptime_percent,
+    (
+        SUM (
+            CASE
+                WHEN
+                    v3_5_statistics_hosts_resources_usage_samples.host_status 
= 2
+                    THEN
+                        COALESCE (
+                            
v3_5_statistics_hosts_resources_usage_samples.minutes_in_status,
+                            0
+                        )
+                ELSE 0
+            END
+        ) /
+        SUM (
+            v3_5_statistics_hosts_resources_usage_samples.minutes_in_status
+        )
+    ) * 100
+    AS planned_downtime_percent,
+    (
+        SUM (
+            CASE
+                WHEN
+                    v3_5_statistics_hosts_resources_usage_samples.host_status 
= 3
+                    THEN
+                        COALESCE (
+                            
v3_5_statistics_hosts_resources_usage_samples.minutes_in_status,
+                            0
+                        )
+                ELSE 0
+            END
+        ) /
+        SUM (
+            v3_5_statistics_hosts_resources_usage_samples.minutes_in_status
+        )
+    ) * 100
+    AS unplanned_downtime_percent
 FROM v3_5_statistics_hosts_resources_usage_samples
-     INNER JOIN v3_5_latest_configuration_hosts ON 
(v3_5_latest_configuration_hosts.host_id = 
v3_5_statistics_hosts_resources_usage_samples.host_id)
-WHERE v3_5_latest_configuration_hosts.cluster_id = cast($P{P_Cluster_ID} as 
UUID)
-GROUP BY v3_5_latest_configuration_hosts.host_id, 
v3_5_latest_configuration_hosts.host_name
-ORDER BY uptime_percent ASC, unplanned_downtime_percent DESC, 
planned_downtime_percent DESC
+    INNER JOIN v3_5_latest_configuration_hosts
+        ON (
+            v3_5_latest_configuration_hosts.host_id =
+            v3_5_statistics_hosts_resources_usage_samples.host_id
+        )
+WHERE
+    -- Here we filter by the cluster chosen by the user
+    v3_5_latest_configuration_hosts.cluster_id =
+    CAST ( $P{P_Cluster_ID} as UUID )
+GROUP BY
+    v3_5_latest_configuration_hosts.host_id,
+    v3_5_latest_configuration_hosts.host_name
+ORDER BY
+    uptime_percent ASC,
+    unplanned_downtime_percent DESC,
+    planned_downtime_percent DESC
 LIMIT 5]]>
        </queryString>
        <field name="host_id" class="java.lang.Object"/>
@@ -29,7 +96,7 @@
                <band height="260" splitType="Stretch">
                        <stackedBarChart>
                                <chart evaluationTime="Report" 
customizerClass="com.ovirt.reports.jasper.DrStackedBarChartCustomizer" 
theme="WebadminLineBarChartTheme">
-                                       <reportElement 
uuid="dc298783-7b10-4fde-bf45-dd2bad14bb5a" mode="Transparent" x="0" y="0" 
width="445" height="260"/>
+                                       <reportElement mode="Transparent" x="0" 
y="0" width="445" height="260" uuid="dc298783-7b10-4fde-bf45-dd2bad14bb5a"/>
                                        <chartTitle>
                                                <font fontName="SansSerif" 
size="10"/>
                                                
<titleExpression><![CDATA[$R{dr18.title}]]></titleExpression>


-- 
To view, visit http://gerrit.ovirt.org/27884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3193e16cd226a91e4f44084555763c48b3360100
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to