Shahar Havivi has posted comments on this change. Change subject: Engine: add Admin password and OrgName for Sysprep ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/27642/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java: Line 707: getCloudInitRootPasswordVerification().setIsValid(true); Line 708: Line 709: if (getHostnameEnabled()) { Line 710: if (this.isWindowsOS) { Line 711: if (getSysprepPasswordEnabled()) { > I'd say this does not apply only when the hostname is enabled - please move Yes, who wrote that? :) Line 712: getSysprepAdminPassword().validateEntity(new IValidation[] { new NotEmptyValidation(), new MatchFieldsValidator(getSysprepAdminPassword().getEntity(), Line 713: getSysprepAdminPasswordVerification().getEntity()) }); Line 714: } Line 715: getWindowsHostname().validateEntity(new IValidation[] { new HostnameValidation() }); http://gerrit.ovirt.org/#/c/27642/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/MatchFieldsValidator.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/MatchFieldsValidator.java: Line 25: ArrayList<String> reasons = new ArrayList<String>(); Line 26: reasons.add(ConstantsManager.getInstance().getConstants().cloudInitRootPasswordMatchMessage()); Line 27: rs.setReasons(reasons); Line 28: } else { Line 29: rs.setSuccess(true); > this would pass even if one of the passwords was null. I'd use something li Done Line 30: } Line 31: return rs; Line 32: } Line 33: } -- To view, visit http://gerrit.ovirt.org/27642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie33cce7b395ba8e7e7a46bc31a7564410f808888 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
