Alon Bar-Lev has posted comments on this change. Change subject: aaa: Changes to ExtensionsManager ......................................................................
Patch Set 20: (2 comments) http://gerrit.ovirt.org/#/c/27785/20/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 225: } Line 226: } catch (Exception e) { Line 227: throw new RuntimeException(String.format("Error loading extension %1$s", entry.name)); Line 228: } Line 229: loadedEntries.putIfAbsent(entry.name, entry); please put extension only after all is set including global context. Line 230: synchronized (globalContext) { Line 231: globalContext.<List<ExtMap>> get(Base.GlobalContextKeys.EXTENSIONS).add( Line 232: new ExtMap().mput( Line 233: Base.ExtensionRecord.INSTANCE_NAME, http://gerrit.ovirt.org/#/c/27785/20/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java: Line 71: instance.activate( Line 72: extension.getContext().<String> get(Base.ContextKeys.INSTANCE_NAME), Line 73: EngineLocalConfig.getInstance().getBoolean( Line 74: ENGINE_EXTENSION_ENABLED + extension.getContext().<String> get(Base.ContextKeys.INSTANCE_NAME) Line 75: ) hmmm.... this is confusing... took me a while... maybe better to have getExtensionConfiguration(String) in order to allow interception? Line 76: ); Line 77: } catch (Exception ex) { Line 78: log.error(ex.getMessage()); Line 79: log.debug(ex); -- To view, visit http://gerrit.ovirt.org/27785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
