Lior Vernia has posted comments on this change.

Change subject: webadmin: fixed edit icons in Setup Host Network dialog
......................................................................


Patch Set 2:

(1 comment)

So... In this case as well, things don't look the same on my browser, and the 
pencil icon is a little too low on bonds. I have refreshed Firefox using 
Ctrl+F5 which I think should perform a full refresh, and also cleared cache via 
Firefox preferences.

I think we need to figure out why there are differences between what we see, 
and if it's even possible to have this stuff look okay on both of our 
deployments.

We've established that I'm working on Firefox 22, but I think you check 
multiple versions anyway. I work with no zoom, maybe that's the difference?

http://gerrit.ovirt.org/#/c/27708/2/packaging/branding/ovirt.brand/patternfly-custom-hacks.css
File packaging/branding/ovirt.brand/patternfly-custom-hacks.css:

Line 418:     top: -6px !important;
Line 419: }
Line 420: .bp_actionButton_pfly_fix img {
Line 421:     position: relative;
Line 422:     top: -3px !important;
On my deployment -5px works better.
Line 423:     right: 3px !important;


-- 
To view, visit http://gerrit.ovirt.org/27708
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If85fd9ea6a8b20d91bd88e0d8d736a221dff0c71
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to