Alon Bar-Lev has posted comments on this change. Change subject: aaa: Changes to ExtensionsManager ......................................................................
Patch Set 22: (4 comments) http://gerrit.ovirt.org/#/c/27785/22/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 219: getTraceLog(), Line 220: entry.extension.getContext().get(Base.ContextKeys.EXTENSION_NAME), Line 221: entry.extension.getContext().get(Base.ContextKeys.INSTANCE_NAME) Line 222: ) Line 223: ) > hmm... so how are we going to trace the load? I do not want to skip the name as I would like a way to enable all logging of instances of extension X I think it will be handy when doing support, as we do not care what instances there are. Line 224: ); Line 225: Line 226: ExtMap output = entry.extension.invoke( Line 227: new ExtMap().mput( Line 253: ).mput( Line 254: Base.ExtensionRecord.CONTEXT, Line 255: entry.extension.getContext() Line 256: ) Line 257: ); > didnt you ask in a previous round to move this to load? hmmm: [11:18] <yzaslavs> or some dependency hint [11:18] <alonbl> ok, let's drop ordering for now [11:19] <alonbl> so at initialize set the global context [11:19] <yzaslavs> ok Line 258: } Line 259: loadedEntries.putIfAbsent(entry.name, entry); Line 260: setChanged(); Line 261: notifyObservers(); Line 263: } Line 264: Line 265: public static String getTraceLog() { Line 266: return ExtensionsManager.class.getName() + ".trace"; Line 267: } > as i wrote before, it is not possible to retreive the name of the logger in ok, sorry I missed that. Line 268: Line 269: public ExtMap getGlobalContext() { Line 270: return globalContext; Line 271: } Line 309: public ExtensionProxy initialize(String extensionName) { Line 310: ExtensionEntry entry = loadedEntries.get(extensionName); Line 311: if (entry == null) { Line 312: throw new RuntimeException(String.format("No extensioned with instance name %1$s could be found", Line 313: extensionName)); > getters? what getter would you like to set it besides at getExtensionByNam at least the get by name? whatever you have there condition of == null just to be consistent... not that important. Line 314: } Line 315: try { Line 316: ExtMap output = entry.extension.invoke( Line 317: new ExtMap().mput( -- To view, visit http://gerrit.ovirt.org/27785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
