Omer Frenkel has posted comments on this change. Change subject: backend: Control virtio rng device ......................................................................
Patch Set 21: (2 comments) http://gerrit.ovirt.org/#/c/18176/21/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractRngDeviceCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractRngDeviceCommand.java: Line 24: Line 25: protected AbstractRngDeviceCommand(T parameters) { Line 26: super(parameters); Line 27: Line 28: if (parameters.getRngDevice() == null || parameters.getRngDevice().getVmId() == null) { > To Omer and Roy: I actually added back the null checks here despite the @No agree Line 29: return; Line 30: } Line 31: Line 32: Guid vmId = parameters.getRngDevice().getVmId(); http://gerrit.ovirt.org/#/c/18176/21/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmRngDevice.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmRngDevice.java: Line 67: public static final String BYTES_STRING = "bytes"; Line 68: public static final String PERIOD_STRING = "period"; Line 69: public static final String SOURCE_STRING = "source"; Line 70: Line 71: public static VmRngDevice create(Guid id, Guid vmId, Integer bytes, Integer period, Source source) { why do you need a static method to return an instance? Line 72: return new VmRngDevice(new VmDeviceId(id, vmId), createSpecPars(bytes, period, source)); Line 73: } Line 74: Line 75: public static VmRngDevice fromVmDevice(VmDevice dev) { -- To view, visit http://gerrit.ovirt.org/18176 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc26a484c84244074426f4b0c790e2cc4ebb8da6 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
