Alon Bar-Lev has posted comments on this change.

Change subject: packaging: setup: Introduce plugin for fence_kdump listener
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.ovirt.org/#/c/27486/6/packaging/services/ovirt-fence-kdump-listener/db.py
File packaging/services/ovirt-fence-kdump-listener/db.py:

this does not belong to this patch
Line 1: # Copyright 2014 Red Hat
Line 2: #
Line 3: # Licensed under the Apache License, Version 2.0 (the "License");
Line 4: # you may not use this file except in compliance with the License.


http://gerrit.ovirt.org/#/c/27486/6/packaging/services/ovirt-fence-kdump-listener/options.py
File packaging/services/ovirt-fence-kdump-listener/options.py:

this does not belong to this patch, and I think we should stop playing with 
options and just have the engine options at engine side.
Line 1: # Copyright 2014 Red Hat
Line 2: #
Line 3: # Licensed under the Apache License, Version 2.0 (the "License");
Line 4: # you may not use this file except in compliance with the License.


-- 
To view, visit http://gerrit.ovirt.org/27486
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I052cc2296c479caf58d0930a8e678298dde63517
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to