Omer Frenkel has posted comments on this change. Change subject: core: VdsManager - no need to cache config values ......................................................................
Patch Set 6: Code-Review+1 (2 comments) minor comments http://gerrit.ovirt.org/#/c/27375/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 129: @Override Line 130: public void schedulJobs() { Line 131: SchedulerUtil sched = SchedulerUtilQuartzImpl.getInstance(); Line 132: int refreshRate = Config.<Integer> getValue(ConfigValues.VdsRefreshRate) * 1000; Line 133: white space Line 134: // start with refresh statistics Line 135: _refreshIteration = _numberRefreshesBeforeSave - 1; Line 136: Line 137: onTimerJobId = Line 487: Config.<Integer>getValue(ConfigValues.TimeToReduceFailedRunOnVdsInMinutes), Line 488: TimeUnit.MINUTES); Line 489: AuditLogDirector.log( Line 490: new AuditLogableBase(vds.getId()) Line 491: .addCustomValue("Time", Config.<Integer> getValue(ConfigValues.TimeToReduceFailedRunOnVdsInMinutes).toString()), you could make it a little shorter if you save the config value locally as it is used twice in this method Line 492: AuditLogType.VDS_FAILED_TO_RUN_VMS); Line 493: log.infoFormat("Vds {0} moved to Error mode after {1} attempts. Time: {2}", vds.getName(), Line 494: mFailedToRunVmAttempts, new Date()); Line 495: } -- To view, visit http://gerrit.ovirt.org/27375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfb5a1641038742dd848ee67cb0fe53ce16b7909 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
