Simone Tiraboschi has posted comments on this change. Change subject: First draft for engine-setup splitting ......................................................................
Patch Set 13: The TODOs are not self contained to this patch cause them really depends on how we decide to split. They are mainly related to engine specific/related constants that are now included in files under the common paths creating an unwanted dependency. To solve them we have in general two ways: 1. move back the constant to the common constant file cause it's really common stuff 2. move the piece of code that requires an engine specific constant to an engine specific path cause it's engine specific code and it's not common required code So we need to decide how we wan't to split to choose how we want to solve that TODOs. For instance: the apache related code that now is under plugins/ovirt-engine-common/base/system/ it's really common or it's engine specific? what to do with apache when we are installing an host without the engine? The same for packaging/setup/plugins/ovirt-engine-common/base/db stuff; do we really need it if we are just installing the websocket proxy on a separate host where it doesn't needs any DB connection? We can just leave them under the engine plugin package but we probably need similar code also for DWH and I prefer to avoid any code duplication. Of course we can also put that stuff in a new shared-but-not-really-common package but I'm not sure that it's the easiest and cleaner way. I think we need to clarify these points before proceeding with that TODOs. -- To view, visit http://gerrit.ovirt.org/27647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d465766f10a490bd213ca3510d02b3d6fdfa7c6 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
