Ori Liel has posted comments on this change. Change subject: REST: Add calls for queries to get unregistered entities. ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/27628/8/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplatesResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplatesResource.java: Line 42: for (org.ovirt.engine.core.common.businessentities.VmTemplate entity : unregisteredTemplates) { Line 43: Template vmTemplate = map(entity); Line 44: collection.add(addLinks(populate(vmTemplate, entity))); Line 45: } Line 46: templates.getTemplates().addAll(collection); This way it won't return any Templates unless unregister param is provided, no good... Line 47: } Line 48: return templates; Line 49: } Line 50: http://gerrit.ovirt.org/#/c/27628/8/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResource.java: Line 38: for (org.ovirt.engine.core.common.businessentities.VM entity : unregisteredVms) { Line 39: VM vm = map(entity); Line 40: collection.add(addLinks(populate(vm, entity))); Line 41: } Line 42: vms.getVMs().addAll(collection); This way it won't return any VMs unless unregister param is provided, no good... Line 43: } Line 44: return vms; Line 45: } Line 46: -- To view, visit http://gerrit.ovirt.org/27628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7adacfabe640fba6b0ae1a77d27cbe03c28edd37 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
