Yevgeny Zaspitsky has posted comments on this change. Change subject: restapi: proper asserts in tests ......................................................................
Patch Set 3: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/27772/3//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-05-16 17:47:05 +0300 Line 6: Line 7: restapi: proper asserts in tests Line 8: Line 9: Replace the wrong use of assert with JUnit's proper assertEquals. I disagree with your opinion with regards to "wrong" usage of assert. Please see my comment on AbstractBackendAssignedPermissionsResourceTest. Line 10: Line 11: Change-Id: If4c17c2fda25a0bffa2ba5b78db884a29b4be433 http://gerrit.ovirt.org/#/c/27772/3/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendAssignedPermissionsResourceTest.java File backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendAssignedPermissionsResourceTest.java: Line 201 Line 202 Line 203 Line 204 Line 205 Here assertion is not JUnit one as it does not assert test results, but the Java built-in one and checks the validity of test itself. Failing supplying the query string should lead to test failure rather than error. Line 215 Line 216 Line 217 Line 218 Line 219 same -- To view, visit http://gerrit.ovirt.org/27772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4c17c2fda25a0bffa2ba5b78db884a29b4be433 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
