Yevgeny Zaspitsky has posted comments on this change. Change subject: core: UpdateVmDiskCommand anyList() ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/27770/3/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java: Line 394: } Line 395: }); Line 396: Line 397: initializeCommand(parameters); Line 398: doReturn(true).when(command).validatePciAndIdeLimit(anyList()); anyListOf(VM.class) would save another yellow line Line 399: Line 400: when(diskValidator.isReadOnlyPropertyCompatibleWithInterface()).thenReturn(ValidationResult.VALID); Line 401: when(diskValidator.isDiskInterfaceSupported(any(VM.class))).thenReturn(new ValidationResult(VdcBllMessages.ACTION_TYPE_DISK_INTERFACE_UNSUPPORTED)); Line 402: when(command.getDiskValidator(any(Disk.class))).thenReturn(diskValidator); -- To view, visit http://gerrit.ovirt.org/27770 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09dc46815c8b999e370229eb9d1b92872c4b1053 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
