Yair Zaslavsky has posted comments on this change. Change subject: engine: Introduction of command entity dao ......................................................................
Patch Set 22: (3 comments) http://gerrit.ovirt.org/#/c/26337/22/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 2065: protected void persistCommand(VdcActionType parentCommand) { Line 2066: VdcActionParametersBase parentParameters = getParentParameters(parentCommand); Line 2067: TaskManagerUtil.persistCommand( Line 2068: getCommandId(), Line 2069: getParameters().getParentParameters() == null ? Guid.Empty : getParameters().getParentParameters().getCommandId(), maybe worth inserting the logic of determining the parent command id to the TaskManagerUtil? Line 2070: parentParameters.getCommandId(), Line 2071: getActionType(), Line 2072: getParameters(), Line 2073: commandStatus); Line 2066: VdcActionParametersBase parentParameters = getParentParameters(parentCommand); Line 2067: TaskManagerUtil.persistCommand( Line 2068: getCommandId(), Line 2069: getParameters().getParentParameters() == null ? Guid.Empty : getParameters().getParentParameters().getCommandId(), Line 2070: parentParameters.getCommandId(), isn't this the same as the parameter before? Line 2071: getActionType(), Line 2072: getParameters(), Line 2073: commandStatus); Line 2074: } http://gerrit.ovirt.org/#/c/26337/22/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDaoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDaoDbFacadeImpl.java: Line 52: protected MapSqlParameterSource createFullParametersMapper(CommandEntity entity) { Line 53: return getCustomMapSqlParameterSource().addValue("command_id", entity.getId()) Line 54: .addValue("command_type", entity.getCommandType().getValue()) Line 55: .addValue("parent_command_id", entity.getParentCommandId()) Line 56: .addValue("root_command_id", entity.getRootCommandId()) not sure i have noticed, how do u calculate root command id? Line 57: .addValue("action_parameters", serializeParameters(entity.getActionParameters())) Line 58: .addValue("action_parameters_class", entity.getActionParameters() == null ? null : entity.getActionParameters().getClass().getName()) Line 59: .addValue("status", entity.getCommandStatus().toString()); Line 60: } -- To view, visit http://gerrit.ovirt.org/26337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I463102d85de7558fbcab23585ad6b48cdc35c0a0 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
