Sahina Bose has posted comments on this change. Change subject: engine : Introduce TimeConverter ......................................................................
Patch Set 14: (1 comment) http://gerrit.ovirt.org/#/c/27469/14/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/TimeConverterTest.java File backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/TimeConverterTest.java: Line 10: @Test Line 11: public void testConvertSecondsToMinutes() { Line 12: long seconds = 1800L; Line 13: Pair<Long, TimeUnit> expectedResults = TimeConverter.autoConvert(seconds, TimeUnit.SECONDS); Line 14: assertEquals(expectedResults.getFirst().longValue() , 30L); How about asserting the expected TimeUnit as well? Line 15: } Line 16: Line 17: @Test Line 18: public void testConvertMinutesToHours() { -- To view, visit http://gerrit.ovirt.org/27469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I045aaa4f93b345e0457e1a0ce2ccf0ceeb9071ad Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
