Vojtech Szocs has posted comments on this change. Change subject: webadmin: display tool-tip for disabled editors ......................................................................
Patch Set 2: Rebased (no additional changes). Nice patch! HasEnabled interface covers both typical cases for disabling EntityModel's editor widget: 1. Disabling EntityModel editor because some operation is in progress (e.g. login input fields disabled after initiating login operation), or because EntityModel's editor is not available in some context (e.g. in VM -> New Network Interface dialog, MAC input field is disabled unless you click "Specify custom MAC address"). In this case, setEnabled(boolean) makes sense. 2. Disabling EntityModel editor because of some business rule or restriction, where an explanatory tooltip would be useful to the user. In this case, setEnabled(boolean,List<String>) makes sense. Just one question: in setEnabled(boolean,List<String>) method, disabilityHints parameter makes sense only when enabled == false, right? -- To view, visit http://gerrit.ovirt.org/5163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id74f1f082219fbd4d0042ec08f926b8861500745 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
