Martin Sivák has posted comments on this change. Change subject: storage: iscsi: ensure service directory exists ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/27994/1/ovirt_hosted_engine_ha/lib/storage_backends.py File ovirt_hosted_engine_ha/lib/storage_backends.py: Line 144: # but if anything else happened, raise it again Line 145: raise Line 146: try: Line 147: if not os.path.exists(self._storage_path): Line 148: os.mkdir(self._storage_path) > drop the os.path.exists test - it's racy anyway and just call the os.mkdir We already use util.mkdir_recursive(self._storage_path) in the create method. Line 149: os.symlink(os.path.join("/dev", uuid, lv), service_link) Line 150: except OSError as e: Line 151: raise Exception( Line 152: "%s -> %s failed: %s" % ( -- To view, visit http://gerrit.ovirt.org/27994 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1d4783437236b495b2ca5424185aeac9eb8ba72 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
