Sandro Bonazzola has posted comments on this change. Change subject: Fix libvirt's getSchedulerParameters call ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28044/1/mom/HypervisorInterfaces/libvirtInterface.py File mom/HypervisorInterfaces/libvirtInterface.py: Line 256: else: Line 257: ret['vcpu_user_limit'] = 100 Line 258: Line 259: # Retrieve the current cpu tuning params Line 260: ret.update(domain.getSchedulerParameters(('vcpu_quota', 'vcpu_period'))) if this is intended to be a set, then you're missing a call to set(...) Line 261: Line 262: if ret['vcpu_quota'] == None: Line 263: ret['vcpu_quota'] = -1 Line 264: -- To view, visit http://gerrit.ovirt.org/28044 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb4ef21f8d56363511460667dac359bf7e8b36a7 Gerrit-PatchSet: 1 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
