Fabian Deutsch has posted comments on this change. Change subject: engine_page: catch exception from vdscli.connect() ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/28043/1/src/engine_page.py File src/engine_page.py: Line 66: LOGGER.debug("Connection refused with VDSM", exc_info=True) Line 67: else: Line 68: raise Line 69: except Exception as err: Line 70: if 'No permission to read file:' in str(err): I am not to happy about this handling, but I don't see a better solution for now, if vdsm throws just a general Exception Line 71: LOGGER.debug("pem files not available yet!", exc_info=True) Line 72: else: Line 73: raise Line 74: -- To view, visit http://gerrit.ovirt.org/28043 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a0333837a3aec2364362728951b1623b46065a0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
