Oved Ourfali has posted comments on this change.

Change subject: aaa: Intorduce filters
......................................................................


Patch Set 14: Code-Review+1

(3 comments)

http://gerrit.ovirt.org/#/c/28022/14/backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml
File backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml:

Line 32: 
Line 33:   <filter>
Line 34:     <filter-name>BasicAuthenticationFilter</filter-name>
Line 35:     
<filter-class>org.ovirt.engine.core.aaa.filters.BasicAuthenticationFilter</filter-class>
Line 36:     <init-param> 
remove whitespaces here.
Line 37:       <param-name>user-name-format</param-name>
Line 38:       <param-value>UPN</param-value> 
Line 39:     </init-param> 
Line 40:   </filter>


http://gerrit.ovirt.org/#/c/28022/14/frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml
File frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml:

Line 31: 
Line 32:   <filter>
Line 33:     <filter-name>BasicAuthenticationFilter</filter-name>
Line 34:     
<filter-class>org.ovirt.engine.core.aaa.filters.BasicAuthenticationFilter</filter-class>
Line 35:     <init-param> 
and here.
Line 36:       <param-name>user-name-format</param-name>
Line 37:       <param-value>UPN</param-value> 
Line 38:     </init-param> 
Line 39:   </filter>


http://gerrit.ovirt.org/#/c/28022/14/frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml
File frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml:

Line 46:   <filter>
Line 47:     <filter-name>NegotiationFilter</filter-name>
Line 48:     
<filter-class>org.ovirt.engine.core.aaa.filters.NegotiationFilter</filter-class>
Line 49:     <init-param> 
Line 50:       <param-name>capabilities</param-name>
and here.
Line 51:       <param-value>AUTHENTICATE_NEGOTIATE_INTERACTIVE | 
AUTHENTICATE_NEGOTITATE_NON_INTERACTIVE</param-value> 
Line 52:     </init-param> 
Line 53:   </filter>
Line 54:   <filter-mapping>


-- 
To view, visit http://gerrit.ovirt.org/28022
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5536d123b6407acf41b6946dde796bd67d1e073
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to