Mike Kolesnik has posted comments on this change. Change subject: core: util for removing overlaps in ranges ......................................................................
Patch Set 15: (1 comment) http://gerrit.ovirt.org/#/c/26403/15/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/DisjointRangesTest.java File backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/DisjointRangesTest.java: Line 25: return Arrays.asList(new Object[][]{ Line 26: { Collections.<Pair<Long, Long>>emptyList(), Collections.<Pair<Long, Long>>emptyList(), null, null }, Line 27: { Arrays.asList(pair(1, 2)), Arrays.asList(pair(1, 2)), null, null }, Line 28: { Arrays.asList( pair( 1, 2 ), pair( 3, 4 ) ), Arrays.asList( pair( 1, 2), pair(3, 4 ) ), null, null }, Line 29: { Arrays.asList( pair( 2, 1 ), pair( 3, 4 ) ), Collections.<Pair<Long, Long>>emptyList(), IllegalArgumentException.class, "badly defined range" }, > cannot happen. LongRange implementation fixes this misuse. You're still enforcing it though, so either fix the code or the test (I think the limitation is not interesting in this context, so better fix the code). Line 30: { Arrays.asList( pair( 1, 3 ), pair( 2, 5 ) ), Arrays.asList( pair( 1, 5 ) ), null, null }, Line 31: { Arrays.asList( pair( 1, 3 ), pair( 5, 7 ), pair( 6, 7) ), Arrays.asList( pair( 1, 3 ), pair(5, 7) ), null, null }, Line 32: { Arrays.asList( pair( 1, 2 ), pair( 5, 7 ), pair( 4, 7) ), Arrays.asList( pair( 1, 2 ), pair(4, 7) ), null, null }, Line 33: { Arrays.asList( pair( 1, 3 ), pair( 5, 7 ), pair( 4, 7) ), Arrays.asList( pair( 1, 3), pair(4, 7 ) ), null, null }, -- To view, visit http://gerrit.ovirt.org/26403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7dbacd11b610a5885d574356a695c6e879dcdbc Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
