Livnat Peer has posted comments on this change.
Change subject: core: SetupNetworksHelperTest rework
......................................................................
Patch Set 2: Looks good to me, approved
(3 inline comments)
very good work.
Nice test coverage, we are missing some VLAN basic scenarios but they can be
added in a future patch.
only minor comments were added in-line.
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java
Line 272: public void vlanOverBond() {
please reorder this test as in previous tests:
-create parameters
-mock
-create helper
-validate
Line 415: */
please use more indicative name createBondWithNetwork(String networkName)
Line 456: */
I would use -
@param bondName if bond name is not null the NIC will be create as a slave of
the given bond name.
createNic(String bondName)
--
To view, visit http://gerrit.ovirt.org/5233
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68b69e748d216d119c0ac419358eb4b6c42d7ffe
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
