Liron Ar has posted comments on this change. Change subject: core: Support detach Storage Domain containing entities. ......................................................................
Patch Set 29: (3 comments) http://gerrit.ovirt.org/#/c/24286/29/packaging/dbscripts/vm_templates_sp.sql File packaging/dbscripts/vm_templates_sp.sql: Line 534: INNER JOIN images i ON i.image_group_id = vd.device_id Line 535: INNER JOIN (SELECT image_id Line 536: FROM image_storage_domain_map Line 537: WHERE image_storage_domain_map.storage_domain_id = v_storage_domain_id) isd_map Line 538: ON i.image_guid = isd_map.image_id) vms_with_disks_on_storage_domain ON templates.vmt_guid = vms_with_disks_on_storage_domain.vm_guid /vms_with_disks_on_storage_domain/templates_with_disks_on_storage_domain Line 539: WHERE entity_type = 'TEMPLATE' Line 540: INNER JOIN vm_device vd ON vd.vm_id = templates.vmt_guid Line 541: INNER JOIN images i ON i.image_group_id = vd.device_id Line 542: INNER JOIN image_storage_domain_map on i.image_guid = image_storage_domain_map.image_id Line 535: INNER JOIN (SELECT image_id Line 536: FROM image_storage_domain_map Line 537: WHERE image_storage_domain_map.storage_domain_id = v_storage_domain_id) isd_map Line 538: ON i.image_guid = isd_map.image_id) vms_with_disks_on_storage_domain ON templates.vmt_guid = vms_with_disks_on_storage_domain.vm_guid Line 539: WHERE entity_type = 'TEMPLATE' move to correct place Line 540: INNER JOIN vm_device vd ON vd.vm_id = templates.vmt_guid Line 541: INNER JOIN images i ON i.image_group_id = vd.device_id Line 542: INNER JOIN image_storage_domain_map on i.image_guid = image_storage_domain_map.image_id Line 543: WHERE image_storage_domain_map.storage_domain_id != v_storage_domain_id; http://gerrit.ovirt.org/#/c/24286/29/packaging/dbscripts/vms_sp.sql File packaging/dbscripts/vms_sp.sql: Line 1087: INNER JOIN (SELECT image_id Line 1088: FROM image_storage_domain_map Line 1089: WHERE image_storage_domain_map.storage_domain_id = v_storage_domain_id) isd_map Line 1090: ON i.image_guid = isd_map.image_id) vms_with_disks_on_storage_domain ON vms.vm_guid = vms_with_disks_on_storage_domain.vm_guid Line 1091: WHERE entity_type = 'VM' same Line 1092: INNER JOIN vm_device vd ON vd.vm_id = vms.vm_guid Line 1093: INNER JOIN images i ON i.image_group_id = vd.device_id Line 1094: INNER JOIN image_storage_domain_map on i.image_guid = image_storage_domain_map.image_id Line 1095: WHERE image_storage_domain_map.storage_domain_id != v_storage_domain_id; -- To view, visit http://gerrit.ovirt.org/24286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I971fe6acd4a2667a09487c5e1108cf7c759587f1 Gerrit-PatchSet: 29 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
