Liron Ar has posted comments on this change. Change subject: core: Use import command to register a VM ......................................................................
Patch Set 25: Code-Review+1 (2 comments) I'm not favor of that implementation, i think that we should change it to a simpler one. as we need it in marking +1. http://gerrit.ovirt.org/#/c/27247/25/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java: Line 42: @Override Line 43: protected boolean canDoAction() { Line 44: if (isImagesAlreadyOnTarget()) { Line 45: if (ovfEntityData == null && !getParameters().isImportAsNewEntity()) { Line 46: //addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_UNSUPPORTED_OVF); fix Line 47: return false; Line 48: } Line 49: Line 50: setStorageDomainId(ovfEntityData.getStorageDomainId()); http://gerrit.ovirt.org/#/c/27247/25/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 1067: MIGRATE_PAUSED_ERR_VM_IS_UNSUPPORTED=Migrating a VM in paused status due to an error is unsupported. Line 1068: VM_INTERFACE_NOT_EXIST=Cannot ${action} ${type}. The VM Network Interface does not exist. Line 1069: HOST_NETWORK_INTERFACE_NOT_EXIST=Cannot ${action} ${type}. The host network interface does not exist. Line 1070: ACTION_TYPE_FAILED_CANNOT_REMOVE_ACTIVE_DEVICE=Cannot ${action} ${type}. The VM Network Interface is plugged to a running VM. Line 1071: ACTION_TYPE_FAILED_IMPORT_UNREGISTERED_NOT_COLLAPSED=Cannot ${action} ${type}. Unregistered VM can not be collapsed. /s/Copy-Collapse isn't supported when registering VM. Line 1072: VDS_GROUP_ENABLING_BOTH_VIRT_AND_GLUSTER_SERVICES_NOT_ALLOWED=Cannot ${action} ${type}. Enabling both Virt and Gluster services is not allowed. Line 1073: ENGINE_IS_RUNNING_IN_MAINTENANCE_MODE=Engine is running in Maintenance mode and is not accepting commands. Line 1074: ENGINE_IS_RUNNING_IN_PREPARE_MODE=This action is not allowed when Engine is preparing for maintenance. Line 1075: ACTION_TYPE_FAILED_SERVER_NAME_REQUIRED=Cannot ${action} ${type}. Server Name required. -- To view, visit http://gerrit.ovirt.org/27247 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ee64651eb614feb6ac9d7fde88a4ee6348aff06 Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
