Livnat Peer has posted comments on this change. Change subject: core: Overhaul SetupNetworksHelper ......................................................................
Patch Set 2: I would prefer that you didn't submit this (3 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java Line 99: */ you also add the network to the list of processed interfaces in this method which does not reflect in the method name. /** ... @return <code/> true </code> if interface was added successfully, false if interface was already processed **/ addInterfaceToProcessedList() Line 206: */ what if the bond is not in the bonds list when this method is called? Line 264: */ /s/Remove/Removed -- To view, visit http://gerrit.ovirt.org/5234 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96266c56b0d7f2d0c6aacb45e4a39087f94258f1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
