Vinzenz Feenstra has posted comments on this change. Change subject: Implement default configuration values ......................................................................
Patch Set 10: Verified+1 (1 comment) Verified on Win7 with python2.6 in py2exe mode Verified on F20 with python2.7 Scenarios verified: - Clean install [OK] - Modified conf + upgrade [OK] - Unmodified conf + upgrade [OK] http://gerrit.ovirt.org/#/c/28045/10/ovirt-guest-agent/OVirtGuestService.py File ovirt-guest-agent/OVirtGuestService.py: Line 52: AGENT_DEFAULT_CONFIG = os.path.join(filePath, AGENT_DEFAULT_CONFIG) Line 53: AGENT_DEFAULT_LOG_CONFIG = os.path.join(filePath, Line 54: AGENT_DEFAULT_LOG_CONFIG) Line 55: Line 56: cparser = ConfigParser.ConfigParser() I know this is an ugly duplication (also in ovirt-guest-agent.py) but I don't have currently any common file where I could put this part. I will have to refactor this out later. Line 57: if os.path.exists(AGENT_DEFAULT_LOG_CONFIG): Line 58: cparser.read(AGENT_DEFAULT_LOG_CONFIG) Line 59: cparser.read(AGENT_CONFIG) Line 60: strio = cStringIO.StringIO() -- To view, visit http://gerrit.ovirt.org/28045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ce9d457e826448aad205ce4abda5dc4b0210804 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
