Liron Ar has posted comments on this change. Change subject: core: Adding import of unregistered VM template ......................................................................
Patch Set 20: (1 comment) http://gerrit.ovirt.org/#/c/27581/20/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java: Line 67: if (ovfEntityData != null) { Line 68: try { Line 69: vmFromConfiguration = ovfHelper.readVmTemplateFromOvf(ovfEntityData.getOvfData()); Line 70: } catch (OvfReaderException e) { Line 71: log.errorFormat("failed to parse a given ovf configuration: \n" + ovfEntityData.getOvfData(), e); add CDA here and return false, if it fails you'll end up with null vmTemplate which will cause to an NPE. as it shouldn't happen i assume that we can solve it in the opened bug. Line 72: } Line 73: vmFromConfiguration.setVdsGroupId(getParameters().getVdsGroupId()); Line 74: setVmTemplate(vmFromConfiguration); Line 75: getParameters().setVmTemplate(vmFromConfiguration); -- To view, visit http://gerrit.ovirt.org/27581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fc184e687cbeebf4aa732c901f98222d5b11097 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
