Martin Peřina has posted comments on this change. Change subject: fklsnr: Introduce standalone fence_kdump listener ......................................................................
Patch Set 12: (2 comments) http://gerrit.ovirt.org/#/c/27201/12/packaging/services/ovirt-fence-kdump-listener/listener.py File packaging/services/ovirt-fence-kdump-listener/listener.py: Line 191: ): Line 192: self._dao.update_heartbeat() Line 193: self._lastHeartbeat = datetime.datetime.utcnow() Line 194: Line 195: def _save_sessions(self): > yes, I want heartbeat interval and database sync at different intervals. Done Line 196: # update db state for all updated sessions Line 197: for session in self._sessions.values(): Line 198: if session['dirty']: Line 199: rows_updated = self._dao.update_vds_kdump_status( Line 237: Line 238: self._afterFirstDbSync = True Line 239: Line 240: def _db_sync(self): Line 241: if self._db_manager.validate_connection(): > I do not follow... but please add reconnect interval. Done Line 242: self._db_connection_valid = True Line 243: try: Line 244: self._heartbeat() Line 245: self._save_sessions() -- To view, visit http://gerrit.ovirt.org/27201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieec3bad47bbba860a52a9ff4e2eb7f61277f4e36 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
