Itamar Heim has posted comments on this change.

Change subject: core: Explicit permission when adding a template
......................................................................


Patch Set 3:

but isn't template_admin an admin role, so won't solve the problem for users?
(actually, i think it should have been a user role, not an admin role, and it 
is probably safe enough to change while admin isn't filtering based on roles...)

--
To view, visit http://gerrit.ovirt.org/5267
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7885c03a09c9315fd8eb2f554bc266250fa7e181
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to