Ravi Nori has posted comments on this change.

Change subject: [WIP] core: introduce AsyncTaskStrategy
......................................................................


Patch Set 3: Code-Review-1

Hi Greg,

The approach you have taken here with modifying AsyncTaskManager to handle live 
merge was not accepted in the team meeting. Please change the approach here to 
use the intergace provided by CommandCoordinator to persistCommand and 
retriveCommand. 

Your code should not touch any of the AsyncTaskManager infrastructure code and 
should only work with the methods provided at the TaskManagerUtil level.

-- 
To view, visit http://gerrit.ovirt.org/26912
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460b98c3d4b38243da61433d08c16f1cde5b9e17
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to